Make drover not eliminate '-'s from commit messages....

Make drover not eliminate '-'s from commit messages.

BUG=none
TEST=drover still works as before, but hyphens are no longer eliminated from commit messages

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48771

[viettrungluu, 2010-06-02 17:50:16]

Stop eating my hyphens!

[Peter Kasting, 2010-06-02 18:07:36]

+1 on fixing this bug!

http://codereview.chromium.org/2488004/diff/1/2
File drover.py (right):

http://codereview.chromium.org/2488004/diff/1/2#newcode2
drover.py:2: # Copyright (c) 2009 The Chromium Authors. All rights reserved.
Nit: 2010

http://codereview.chromium.org/2488004/diff/1/2#newcode154
drover.py:154: # any '\r's; the "+ '\n'" matches the previous behaviour of this
function.
"The + \n matches the previous behavior of this function" is a useless comment
for someone reading the code, as they can't see what the previous behavior of
the function was just by looking.  Remove this and replace with a rationale for
why you're doing it, or a description atop this function of the format that it
produces, or some similarly useful comment.

[viettrungluu, 2010-06-02 18:21:42]

Thanks.

http://codereview.chromium.org/2488004/diff/1/2
File drover.py (right):

http://codereview.chromium.org/2488004/diff/1/2#newcode2
drover.py:2: # Copyright (c) 2009 The Chromium Authors. All rights reserved.
On 2010/06/02 18:07:36, Peter Kasting wrote:
> Nit: 2010

Done.

http://codereview.chromium.org/2488004/diff/1/2#newcode154
drover.py:154: # any '\r's; the "+ '\n'" matches the previous behaviour of this
function.
On 2010/06/02 18:07:36, Peter Kasting wrote:
> "The + \n matches the previous behavior of this function" is a useless comment
> for someone reading the code, as they can't see what the previous behavior of
> the function was just by looking.  Remove this and replace with a rationale
for
> why you're doing it, or a description atop this function of the format that it
> produces, or some similarly useful comment.

You're right. I just got rid of it and fixed it where it should've been fixed in
the first place.

[Peter Kasting, 2010-06-02 18:28:33]

http://codereview.chromium.org/2488004/diff/1/2
File drover.py (right):

http://codereview.chromium.org/2488004/diff/1/2#newcode154
drover.py:154: # any '\r's; the "+ '\n'" matches the previous behaviour of this
function.
On 2010/06/02 18:21:42, viettrungluu wrote:
> I just got rid of it and fixed it where it should've been fixed in
> the first place.

Thanks, much more sane.

I unfortunately don't know enough Python to r+ you.

[laforge, 2010-06-02 21:46:05]

LGTM

On Wed, Jun 2, 2010 at 11:28 AM, <pkasting@chromium.org> wrote:

>
> http://codereview.chromium.org/2488004/diff/1/2
> File drover.py (right):
>
> http://codereview.chromium.org/2488004/diff/1/2#newcode154
> drover.py:154: # any '\r's; the "+ '\n'" matches the previous behaviour
> of this function.
> On 2010/06/02 18:21:42, viettrungluu wrote:
>
>> I just got rid of it and fixed it where it should've been fixed in
>> the first place.
>>
>
> Thanks, much more sane.
>
> I unfortunately don't know enough Python to r+ you.
>
>
> http://codereview.chromium.org/2488004/show
>