Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: drover.py

Issue 2488004: Make drover not eliminate '-'s from commit messages.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/tools/depot_tools/
Patch Set: Don't need extra newline. Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: drover.py
===================================================================
--- drover.py (revision 48734)
+++ drover.py (working copy)
@@ -1,5 +1,5 @@
#!/usr/bin/python
-# Copyright (c) 2009 The Chromium Authors. All rights reserved.
+# Copyright (c) 2010 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
@@ -150,14 +150,9 @@
shell=True,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE).stdout.readlines()
- log = ""
- pos = 0
- for line in svn_log:
- if (pos > 2):
- log += line.replace('-','').replace('\r','')
- else:
- pos = pos + 1
- return log
+ # Don't include the header lines and the trailing "---..." line and eliminate
+ # any '\r's.
+ return ''.join([l.replace('\r','') for l in svn_log[3:-1]])
def getSVNVersionInfo():
"""Extract version information from SVN"""
@@ -528,7 +523,7 @@
out.write(action +" " + str(revision) + " - ")
out.write(getRevisionLog(url, revision))
if (author):
- out.write("TBR=" + author)
+ out.write("\nTBR=" + author)
out.close()
change_cmd = 'change ' + str(revision) + " " + filename
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698