Issue 246094: Fixes a compile error due to an call to an incorrect function to get the leng...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246094: Fixes a compile error due to an call to an incorrect function to get the leng... (Closed)

Created:
11 years, 2 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes a compile error due to an call to an incorrect function to get the length. TBR=tommi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28052

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome_frame/test/net/fake_external_tab.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

11 years, 2 months ago (2009-10-06 05:04:36 UTC) #2

lgtm.
(did this recently change?)

On Mon, Oct 5, 2009 at 5:51 PM, <ananta@chromium.org> wrote:

> Reviewers: tommi,
>
> Description:
> Fixes a compile error due to an call to an incorrect function to get the
> length.
>
> TBR=tommi
>
>
> Please review this at http://codereview.chromium.org/246094
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/net/fake_external_tab.cc
>
>
> Index: chrome_frame/test/net/fake_external_tab.cc
> ===================================================================
> --- chrome_frame/test/net/fake_external_tab.cc  (revision 27993)
> +++ chrome_frame/test/net/fake_external_tab.cc  (working copy)
> @@ -329,7 +329,7 @@
>  }
>
>  void FilterDisabledTests() {
> -  if (::testing::FLAGS_gtest_filter.GetLength() &&
> +  if (::testing::FLAGS_gtest_filter.length() &&
>       ::testing::FLAGS_gtest_filter.Compare("*") != 0) {
>     // Don't override user specified filters.
>     return;
>
>
>

Expand Messages | Collapse Messages