Issue 245020: Fix the linux shared build for common_constants....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 245020: Fix the linux shared build for common_constants.... (Closed)

Created:
11 years, 2 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix the linux shared build for common_constants. BUG=none TEST=Linux shared build. TBR=maruel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27332

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/chrome.gyp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

11 years, 2 months ago (2009-09-26 22:48:44 UTC) #2

lgtm

On Sep 26, 2009 6:35 PM, <thestig@chromium.org> wrote:


Reviewers: Marc-Antoine Ruel,

Description:
Fix the linux shared build for common_constants.

BUG=none
TEST=Linux shared build.
TBR=maruel

Please review this at http://codereview.chromium.org/245020

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
 M     chrome/chrome.gyp


Index: chrome/chrome.gyp
===================================================================
--- chrome/chrome.gyp   (revision 27329)
+++ chrome/chrome.gyp   (working copy)
@@ -399,6 +399,11 @@
      'dependencies': [
        '../base/base.gyp:base',
      ],
+      'conditions': [
+        ['OS=="linux"', {
+          'dependencies': ['../build/linux/system.gyp:gtk'],
+        }],
+      ],
      'sources': [
        'common/chrome_constants.cc',
        'common/chrome_constants.h',

Expand Messages | Collapse Messages