Add Workers valgrind failures (mem leaks) to Mac suppression lists. They are ...

Add Workers valgrind failures (mem leaks) to Mac suppression lists. They are already in the Win+Linux list.
BUG=22923, 22932
TEST=remove suppressions and nothing bad happens.
TBR=leiz

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27170

[Lei Zhang, 2009-09-25 04:46:09]

LGTM

[not_the_right_dank, 2009-09-25 04:47:56]

Wait, why do they need to be in both lists?  The generic list should
be fine for both.  Maybe you just need to widen the generic
suppression?

On Thu, Sep 24, 2009 at 9:32 PM,  <dimich@chromium.org> wrote:
>
> Reviewers: leiz,
>
> Description:
> Add Workers valgrind failures (mem leaks) to Mac suppression lists. They =
are
> already in the Win+Linux list.
> BUG=3D22923,22932
> TEST=3Dremove suppressions and nothing bad happens.
>
> Please review this at http://codereview.chromium.org/245001
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 tools/valgrind/memcheck/suppressions_mac.txt
>
>
> Index: tools/valgrind/memcheck/suppressions_mac.txt
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- tools/valgrind/memcheck/suppressions_mac.txt =A0 =A0 =A0 =A0(revision=
 27153)
> +++ tools/valgrind/memcheck/suppressions_mac.txt =A0 =A0 =A0 =A0(working =
copy)
> @@ -858,3 +858,22 @@
> =A0 =A0fun:_ZN3net22MacTrustedCertificates27CopyTrustedCertificateArrayEv
> =A0 =A0fun:_ZNK3net15X509Certificate6VerifyERKSsiPNS_16CertVerifyResultE
> =A0}
> +{
> + =A0 bug_22923
> + =A0 Memcheck:Leak
> + =A0 ...
> + =A0 fun:_ZN16ChildProcessHost13CreateChannelEv
> + =A0 fun:_ZN17WorkerProcessHost4InitEv
> +
> fun:_ZN13WorkerService21CreateDedicatedWorkerERK4GURLiiPN3IPC7Message6Sen=
derEii
> + =A0 fun:_ZN21ResourceMessageFilter23OnCreateDedicatedWorkerERK4GURLiPi
> +
> fun:_Z16DispatchToMethodI21ResourceMessageFilterMS0_FvRK4GURLiPiES1_iiEvP=
T_T0_RK6Tuple2IT1_T2_EP6Tuple1IT3_E
> +}
> +{
> + =A0 bug_22932
> + =A0 Memcheck:Leak
> + =A0 ...
> +
> fun:_ZN7WebCore26PlatformMessagePortChannel19postMessageToRemoteEN3WTF10P=
assOwnPtrINS_18MessagePortChannel9EventDataEEE
> +
> fun:_ZN7WebCore18MessagePortChannel19postMessageToRemoteEN3WTF10PassOwnPt=
rINS0_9EventDataEEE
> +
> fun:_ZN7WebCore11MessagePort11postMessageERKNS_6StringEPKN3WTF6VectorINS4=
_6RefPtrIS0_EELm1EEERi
> +
> fun:_ZN7WebCore8V8Custom32v8MessagePortPostMessageCallbackERKN2v89Argumen=
tsE
> +}
> \ No newline at end of file
>
>
>

[Dmitry Titov, 2009-09-25 05:04:41]

Ha, I didn't know that suppression.txt works for all, it looked like _mac is
for mac and another one is for others...

On Thu, Sep 24, 2009 at 9:47 PM, Dan Kegel <dank@kegel.com> wrote:

>
> Wait, why do they need to be in both lists?  The generic list should
> be fine for both.  Maybe you just need to widen the generic
> suppression?
>
> On Thu, Sep 24, 2009 at 9:32 PM,  <dimich@chromium.org> wrote:
> >
> > Reviewers: leiz,
> >
> > Description:
> > Add Workers valgrind failures (mem leaks) to Mac suppression lists. They
> are
> > already in the Win+Linux list.
> > BUG=22923,22932
> > TEST=remove suppressions and nothing bad happens.
> >
> > Please review this at http://codereview.chromium.org/245001
> >
> > SVN Base: svn://chrome-svn/chrome/trunk/src/
> >
> > Affected files:
> >  M     tools/valgrind/memcheck/suppressions_mac.txt
> >
> >
> > Index: tools/valgrind/memcheck/suppressions_mac.txt
> > ===================================================================
> > --- tools/valgrind/memcheck/suppressions_mac.txt        (revision 27153)
> > +++ tools/valgrind/memcheck/suppressions_mac.txt        (working copy)
> > @@ -858,3 +858,22 @@
> >    fun:_ZN3net22MacTrustedCertificates27CopyTrustedCertificateArrayEv
> >    fun:_ZNK3net15X509Certificate6VerifyERKSsiPNS_16CertVerifyResultE
> >  }
> > +{
> > +   bug_22923
> > +   Memcheck:Leak
> > +   ...
> > +   fun:_ZN16ChildProcessHost13CreateChannelEv
> > +   fun:_ZN17WorkerProcessHost4InitEv
> > +
> >
>
fun:_ZN13WorkerService21CreateDedicatedWorkerERK4GURLiiPN3IPC7Message6SenderEii
> > +   fun:_ZN21ResourceMessageFilter23OnCreateDedicatedWorkerERK4GURLiPi
> > +
> >
>
fun:_Z16DispatchToMethodI21ResourceMessageFilterMS0_FvRK4GURLiPiES1_iiEvPT_T0_RK6Tuple2IT1_T2_EP6Tuple1IT3_E
> > +}
> > +{
> > +   bug_22932
> > +   Memcheck:Leak
> > +   ...
> > +
> >
>
fun:_ZN7WebCore26PlatformMessagePortChannel19postMessageToRemoteEN3WTF10PassOwnPtrINS_18MessagePortChannel9EventDataEEE
> > +
> >
>
fun:_ZN7WebCore18MessagePortChannel19postMessageToRemoteEN3WTF10PassOwnPtrINS0_9EventDataEEE
> > +
> >
>
fun:_ZN7WebCore11MessagePort11postMessageERKNS_6StringEPKN3WTF6VectorINS4_6RefPtrIS0_EELm1EEERi
> > +
> >
> fun:_ZN7WebCore8V8Custom32v8MessagePortPostMessageCallbackERKN2v89ArgumentsE
> > +}
> > \ No newline at end of file
> >
> >
> >
>