Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2448583002: Adding browser pixel test for linear-rgb support in Canvas. (Closed)

Created:
4 years, 1 month ago by zakerinasab
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding browser pixel test for linear-rgb support in Canvas. Recetnly the proper plumbing has been added to Canvas such that it renders when linear-rgb color space is used (codereview.chromium.org/2425113002/). This change adds a browser pixel test to see if the rendered Canvas is properly displayed. BUG=657946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/a5d3239d0abd54d3a4d37ae15c6cccd92f6122d0 Cr-Commit-Position: refs/heads/master@{#427425}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing comments. #

Total comments: 5

Patch Set 3 : Addressing comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -1 line) Patch
A content/test/data/gpu/pixel_canvas_display_linear-rgb.html View 1 1 chunk +44 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_test_pages.py View 1 2 1 chunk +22 lines, -1 line 0 comments Download

Messages

Total messages: 18 (6 generated)
zakerinasab
New patch submitted. I checked the pixel tests locally. All three generate the expected output.
4 years, 1 month ago (2016-10-24 20:22:57 UTC) #3
xidachen
https://codereview.chromium.org/2448583002/diff/1/content/test/data/gpu/pixel_canvas_display_linear-rgb.html File content/test/data/gpu/pixel_canvas_display_linear-rgb.html (right): https://codereview.chromium.org/2448583002/diff/1/content/test/data/gpu/pixel_canvas_display_linear-rgb.html#newcode1 content/test/data/gpu/pixel_canvas_display_linear-rgb.html:1: <!DOCTYPE html> Please use one of the "pixel_offscreenCanvas" tests ...
4 years, 1 month ago (2016-10-24 20:30:18 UTC) #4
zakerinasab
New patch submitted. https://codereview.chromium.org/2448583002/diff/1/content/test/data/gpu/pixel_canvas_display_linear-rgb.html File content/test/data/gpu/pixel_canvas_display_linear-rgb.html (right): https://codereview.chromium.org/2448583002/diff/1/content/test/data/gpu/pixel_canvas_display_linear-rgb.html#newcode1 content/test/data/gpu/pixel_canvas_display_linear-rgb.html:1: <!DOCTYPE html> On 2016/10/24 20:30:18, xidachen ...
4 years, 1 month ago (2016-10-24 20:53:41 UTC) #5
Justin Novosad
non-owner lgtm with question.
4 years, 1 month ago (2016-10-24 21:17:48 UTC) #6
Justin Novosad
Eh... here is the question. https://codereview.chromium.org/2448583002/diff/20001/content/test/data/gpu/pixel_canvas_display_linear-rgb.html File content/test/data/gpu/pixel_canvas_display_linear-rgb.html (right): https://codereview.chromium.org/2448583002/diff/20001/content/test/data/gpu/pixel_canvas_display_linear-rgb.html#newcode8 content/test/data/gpu/pixel_canvas_display_linear-rgb.html:8: var g_swapsBeforeAck = 15; ...
4 years, 1 month ago (2016-10-24 21:22:27 UTC) #7
xidachen
+kbr https://codereview.chromium.org/2448583002/diff/20001/content/test/data/gpu/pixel_canvas_display_linear-rgb.html File content/test/data/gpu/pixel_canvas_display_linear-rgb.html (right): https://codereview.chromium.org/2448583002/diff/20001/content/test/data/gpu/pixel_canvas_display_linear-rgb.html#newcode8 content/test/data/gpu/pixel_canvas_display_linear-rgb.html:8: var g_swapsBeforeAck = 15; On 2016/10/24 21:22:27, Justin ...
4 years, 1 month ago (2016-10-25 00:58:35 UTC) #9
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/2448583002/diff/20001/content/test/data/gpu/pixel_canvas_display_linear-rgb.html File content/test/data/gpu/pixel_canvas_display_linear-rgb.html (right): https://codereview.chromium.org/2448583002/diff/20001/content/test/data/gpu/pixel_canvas_display_linear-rgb.html#newcode8 content/test/data/gpu/pixel_canvas_display_linear-rgb.html:8: var g_swapsBeforeAck = 15; On 2016/10/25 00:58:35, xidachen wrote: ...
4 years, 1 month ago (2016-10-25 01:03:29 UTC) #10
zakerinasab
New patch submitted. Regarding the quarter second wait, Xida suggests to keep it in this ...
4 years, 1 month ago (2016-10-25 14:12:49 UTC) #11
Ken Russell (switch to Gerrit)
I defer to junov's review, but this lgtm fwiw.
4 years, 1 month ago (2016-10-25 17:18:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448583002/40001
4 years, 1 month ago (2016-10-25 17:41:22 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-25 18:51:00 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 19:09:17 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a5d3239d0abd54d3a4d37ae15c6cccd92f6122d0
Cr-Commit-Position: refs/heads/master@{#427425}

Powered by Google App Engine
This is Rietveld 408576698