content/test/data/gpu/pixel_canvas_display_linear-rgb.html - Issue 2448583002: Adding browser pixel test for linear-rgb support in Canvas.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/gpu/pixel_canvas_display_linear-rgb.html

Issue 2448583002: Adding browser pixel test for linear-rgb support in Canvas. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	xidachen 2016/10/24 20:30:18 Please use one of the "pixel_offscreenCanvas" test Please use one of the "pixel_offscreenCanvas" tests as reference. I believe you need some kind of waitForFinish() function, which basically ask the browser to freeze for certain amount of time (250ms I believe) some that there will be time for capturing screenshot of the browser window. zakerinasab 2016/10/24 20:53:41 Done. Show quoted text On 2016/10/24 20:30:18, xidachen wrote: > Please use one of the "pixel_offscreenCanvas" tests as reference. I believe you > need some kind of waitForFinish() function, which basically ask the browser to > freeze for certain amount of time (250ms I believe) some that there will be time > for capturing screenshot of the browser window. Done.
	2 <canvas id="cnv" width=100 height=100></canvas>

	3

	4 <script>

	5 // This layout test checks if the 2D canvas is properly displayed

	6 // when the color space is set to linear-rgb.

	7 var ctx = document.getElementById("cnv").getContext("2d", {colorSpace:'linea r-rgb'});

	8 ctx.fillStyle = 'blue';
	xidachen 2016/10/24 20:30:18 Fill the entire canvas could hide bugs sometimes. Fill the entire canvas could hide bugs sometimes. We have experienced bugs that the rendered images are upside-down, but filling the entire canvas to be blue won't catch that bug. I would recommend changing this test to fill in 22 blocks, each block is 5050 pixels, and fill red, green on top row, and blue, black on the bottom row. zakerinasab 2016/10/24 20:53:41 Done. Show quoted text On 2016/10/24 20:30:18, xidachen wrote: > Fill the entire canvas could hide bugs sometimes. We have experienced bugs that > the rendered images are upside-down, but filling the entire canvas to be blue > won't catch that bug. I would recommend changing this test to fill in 22 > blocks, each block is 5050 pixels, and fill red, green on top row, and blue, > black on the bottom row. Done.
	9 ctx.fillRect(0,0,100,100);

	10 ctx.stroke();

	11 </script>

	12

	13

OLD	NEW

« no previous file with comments | « no previous file | content/test/gpu/gpu_tests/pixel_expectations.py » ('j') | no next file with comments »