Issue 2447002: Fix broken "gcl diff cl" command. We need to use full paths, not...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2447002: Fix broken "gcl diff cl" command. We need to use full paths, not... (Closed)

Created:
10 years, 6 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
Finnur, M-A Ruel

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Fix broken "gcl diff cl" command. We need to use full paths, not relative path. bug:45589 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48680

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	gcl.py	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Nicolas Sylvain

Marc-Antoine: Do we need fixes like that everywhere? If you want to fix it your ...

10 years, 6 months ago (2010-06-01 22:57:19 UTC) #2

M-A Ruel

10 years, 6 months ago (2010-06-01 23:35:10 UTC) #4

it'd be simpler to just os.chdir() but I think it's fine this way too.

lgtm