Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: gcl.py

Issue 2447002: Fix broken "gcl diff cl" command. We need to use full paths, not... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
===================================================================
--- gcl.py (revision 48639)
+++ gcl.py (working copy)
@@ -1166,10 +1166,14 @@
files = change_info.GetFileNames()
else:
files = GetFilesNotInCL()
- return RunShellWithReturnCode(['svn', 'diff'] + files + args,
- print_output=True)[1]
+ root = GetRepositoryRoot()
+ cmd = ['svn', 'diff']
+ cmd.extend([os.path.join(root, x) for x in files])
+ cmd.extend(args)
+ return RunShellWithReturnCode(cmd, print_output=True)[1]
+
@no_args
def CMDsettings():
"""Prints code review settings for this checkout."""
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698