Issue 2441002: ARM: Add more logic to the generic keyed load stub...

Issue 2441002: ARM: Add more logic to the generic keyed load stub... (Closed)

Created:
10 years, 6 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Add more logic to the generic keyed load stub The generic keyed load stub was missing converting string keys to numberign keys and lookup in the keyed lookup cache. This is now added together with an additional counter on all platforms. Committed: http://code.google.com/p/v8/source/detail?r=4773

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 9

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+195 lines, -54 lines)			Patch
M	src/arm/assembler-arm.h	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/arm/ic-arm.cc	View	1 2 3 4	10 chunks	+166 lines, -47 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1 2 3 4	5 chunks	+12 lines, -3 lines	0 comments	Download
M	src/v8-counters.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1 2 3 4	5 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/2441002/diff/13001/4003 File src/arm/ic-arm.cc (right): http://codereview.chromium.org/2441002/diff/13001/4003#newcode58 src/arm/ic-arm.cc:58: // The three scratch registers needs to be ...

10 years, 6 months ago (2010-06-01 18:37:30 UTC) #2

Søren Thygesen Gjesse

10 years, 6 months ago (2010-06-01 21:03:54 UTC) #4

http://codereview.chromium.org/2441002/diff/13001/4003
File src/arm/ic-arm.cc (right):

http://codereview.chromium.org/2441002/diff/13001/4003#newcode58
src/arm/ic-arm.cc:58: // The three scratch registers needs to be different from
the receiver, name and
On 2010/06/01 18:37:30, Erik Corry wrote:
> registers needs -> registers need

Done.

http://codereview.chromium.org/2441002/diff/13001/4003#newcode924
src/arm/ic-arm.cc:924: __ jmp(&index_smi);
On 2010/06/01 18:37:30, Erik Corry wrote:
> I think here and at the destination there should be a comment with what is
> expected to be in which register.

Done.

http://codereview.chromium.org/2441002/diff/13001/4004
File src/ia32/ic-ia32.cc (right):

http://codereview.chromium.org/2441002/diff/13001/4004#newcode411
src/ia32/ic-ia32.cc:411: // ecx: key map
On 2010/06/01 18:37:30, Erik Corry wrote:
> Full stop.
> 

Done.

http://codereview.chromium.org/2441002/diff/13001/4004#newcode491
src/ia32/ic-ia32.cc:491: // eax: key (string)
On 2010/06/01 18:37:30, Erik Corry wrote:
> Full stops.
> 

Done.

Expand Messages | Collapse Messages