Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 244044: Address review comments. (Closed)

Created:
11 years, 2 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
jeremy
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Address review comments. Belongs to http://codereview.chromium.org/254002 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27609

Patch Set 1 #

Total comments: 2

Patch Set 2 : To boldy use the same |switch| style as the rest of our code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M chrome/renderer/render_view.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/render_view_unittest_mac.mm View 1 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/test/render_view_test.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
11 years, 2 months ago (2009-09-30 03:52:19 UTC) #1
jeremy
LGTM Thanks for fixing :) http://codereview.chromium.org/244044/diff/1/3 File chrome/renderer/render_view_unittest_mac.mm (right): http://codereview.chromium.org/244044/diff/1/3#newcode17 Line 17: case kVK_UpArrow: uniChar ...
11 years, 2 months ago (2009-09-30 07:32:02 UTC) #2
Nico
11 years, 2 months ago (2009-09-30 14:58:24 UTC) #3
Thanks. Submitting.

http://codereview.chromium.org/244044/diff/1/3
File chrome/renderer/render_view_unittest_mac.mm (right):

http://codereview.chromium.org/244044/diff/1/3#newcode17
Line 17: case kVK_UpArrow: uniChar = NSUpArrowFunctionKey; break;
On 2009/09/30 07:32:02, jeremy wrote:
> IMHO the body should be indented 2 spaces from the case and on separate lines.

> It's not crazy important to me, but AFAIK this deviates from the rest of the
> code.

Done.

Powered by Google App Engine
This is Rietveld 408576698