Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chrome/renderer/render_view_unittest_mac.mm

Issue 244044: Address review comments. (Closed)
Patch Set: To boldy use the same |switch| style as the rest of our code Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | chrome/test/render_view_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_view_unittest_mac.mm
diff --git a/chrome/renderer/render_view_unittest_mac.mm b/chrome/renderer/render_view_unittest_mac.mm
index e146f1ed4f97ac41fe8ab2727d762489a7515007..c2c766f4fb52badbede9bd894e49b726d6594a4a 100644
--- a/chrome/renderer/render_view_unittest_mac.mm
+++ b/chrome/renderer/render_view_unittest_mac.mm
@@ -12,12 +12,16 @@
#include <Carbon/Carbon.h> // for the kVK_* constants.
NSEvent* CmdDeadKeyEvent(NSEventType type, unsigned short code) {
-
UniChar uniChar = 0;
switch(code) {
- case kVK_UpArrow: uniChar = NSUpArrowFunctionKey; break;
- case kVK_DownArrow: uniChar = NSDownArrowFunctionKey; break;
- default: CHECK(false);
+ case kVK_UpArrow:
+ uniChar = NSUpArrowFunctionKey;
+ break;
+ case kVK_DownArrow:
+ uniChar = NSDownArrowFunctionKey;
+ break;
+ default:
+ CHECK(false);
}
NSString* s = [NSString stringWithFormat:@"%C", uniChar];
@@ -36,7 +40,6 @@ NSEvent* CmdDeadKeyEvent(NSEventType type, unsigned short code) {
// Test that cmd-up/down scrolls the page exactly if it is not intercepted by
// javascript.
TEST_F(RenderViewTest, MacTestCmdUp) {
-
// Some preprocessor trickery so that we can have literal html in our source,
// makes it easier to copy html to and from an html file for testing (the
// preprocessor will remove the newlines at the line ends, turning this into
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | chrome/test/render_view_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698