Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 244016: Fix Linux Views build.... (Closed)

Created:
11 years, 2 months ago by Finnur
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix Linux Views build. It requires you to declare all views built an additional time. Sigh... TBR=erikkay BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
11 years, 2 months ago (2009-09-26 03:35:29 UTC) #1
Erik does not do reviews
11 years, 2 months ago (2009-09-26 15:26:44 UTC) #2
LGTM

On Fri, Sep 25, 2009 at 8:35 PM,  <finnur@chromium.org> wrote:
> Reviewers: Erik Kay,
>
> Description:
> Fix Linux Views build.
>
> It requires you to declare all views built an additional time. Sigh...
>
> TBR=3Derikkay
> BUG=3DNone
> TEST=3DNone
>
>
> Please review this at http://codereview.chromium.org/244016
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/chrome.gyp
>
>
> Index: chrome/chrome.gyp
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/chrome.gyp =A0 (revision 27319)
> +++ chrome/chrome.gyp =A0 (working copy)
> @@ -2521,6 +2521,8 @@
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ['include', '^browser/views/bookmark_menu=
_button.cc'],
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ['include', '^browser/views/bookmark_menu=
_button.h'],
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ['include',
> '^browser/views/bookmark_menu_controller_views.cc'],
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0['include', '^browser/views/browser_acti=
ons_container.cc'],
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0['include', '^browser/views/browser_acti=
ons_container.h'],
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ['include', '^browser/views/browser_bubbl=
e_gtk.cc'],
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ['include', '^browser/views/browser_bubbl=
e.cc'],
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ['include', '^browser/views/browser_bubbl=
e.h'],
>
>
>

Powered by Google App Engine
This is Rietveld 408576698