Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: base/file_version_info_mac.mm

Issue 243102: Convert base dependencies to use sys_string_conversions instead of the ICU... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/file_util_unittest.cc ('k') | base/i18n/icu_string_conversions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_version_info_mac.mm
===================================================================
--- base/file_version_info_mac.mm (revision 28166)
+++ base/file_version_info_mac.mm (working copy)
@@ -9,6 +9,7 @@
#include "base/file_path.h"
#include "base/logging.h"
#include "base/string_util.h"
+#include "base/utf_string_conversions.h"
FileVersionInfo::FileVersionInfo(NSBundle *bundle) : bundle_(bundle) {
[bundle_ retain];
@@ -43,15 +44,15 @@
}
std::wstring FileVersionInfo::company_name() {
- return L"";
+ return std::wstring();
}
std::wstring FileVersionInfo::company_short_name() {
- return L"";
+ return std::wstring();
}
std::wstring FileVersionInfo::internal_name() {
- return L"";
+ return std::wstring();
}
std::wstring FileVersionInfo::product_name() {
@@ -63,7 +64,7 @@
}
std::wstring FileVersionInfo::comments() {
- return L"";
+ return std::wstring();
}
std::wstring FileVersionInfo::legal_copyright() {
@@ -75,22 +76,22 @@
}
std::wstring FileVersionInfo::file_description() {
- return L"";
+ return std::wstring();
}
std::wstring FileVersionInfo::legal_trademarks() {
- return L"";
+ return std::wstring();
}
std::wstring FileVersionInfo::private_build() {
- return L"";
+ return std::wstring();
}
std::wstring FileVersionInfo::file_version() {
// CFBundleVersion has limitations that may not be honored by a
// proper Chromium version number, so try KSVersion first.
std::wstring version = GetStringValue(L"KSVersion");
- if (version == L"")
+ if (version.empty())
version = GetStringValue(L"CFBundleVersion");
return version;
}
@@ -100,7 +101,7 @@
}
std::wstring FileVersionInfo::special_build() {
- return L"";
+ return std::wstring();
}
std::wstring FileVersionInfo::last_change() {
@@ -132,5 +133,5 @@
std::wstring str;
if (GetValue(name, &str))
return str;
- return L"";
+ return std::wstring();
}
« no previous file with comments | « base/file_util_unittest.cc ('k') | base/i18n/icu_string_conversions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698