Convert base dependencies to use sys_string_conversions instead of the ICU...

base/file_version_info_mac.mm

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_version_info.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/string_util.h"
+#include "base/utf_string_conversions.h"
 
 FileVersionInfo::FileVersionInfo(NSBundle *bundle) : bundle_(bundle) {
   [bundle_ retain];
 }
 
 FileVersionInfo::~FileVersionInfo() {
   [bundle_ release];
 }
 
 // static
@@ skipping 14 matching lines @@
 }
 
 // static
 FileVersionInfo* FileVersionInfo::CreateFileVersionInfo(
     const FilePath& file_path) {
   NSString* path = [NSString stringWithUTF8String:file_path.value().c_str()];
   return new FileVersionInfo([NSBundle bundleWithPath:path]);
 }
 
 std::wstring FileVersionInfo::company_name() {
-  return L"";
+  return std::wstring();
 }
 
 std::wstring FileVersionInfo::company_short_name() {
-  return L"";
+  return std::wstring();
 }
 
 std::wstring FileVersionInfo::internal_name() {
-  return L"";
+  return std::wstring();
 }
 
 std::wstring FileVersionInfo::product_name() {
   return GetStringValue(L"CFBundleName");
 }
 
 std::wstring FileVersionInfo::product_short_name() {
   return GetStringValue(L"CFBundleName");
 }
 
 std::wstring FileVersionInfo::comments() {
-  return L"";
+  return std::wstring();
 }
 
 std::wstring FileVersionInfo::legal_copyright() {
   return GetStringValue(L"CFBundleGetInfoString");
 }
 
 std::wstring FileVersionInfo::product_version() {
   return GetStringValue(L"CFBundleShortVersionString");
 }
 
 std::wstring FileVersionInfo::file_description() {
-  return L"";
+  return std::wstring();
 }
 
 std::wstring FileVersionInfo::legal_trademarks() {
-  return L"";
+  return std::wstring();
 }
 
 std::wstring FileVersionInfo::private_build() {
-  return L"";
+  return std::wstring();
 }
 
 std::wstring FileVersionInfo::file_version() {
   // CFBundleVersion has limitations that may not be honored by a
   // proper Chromium version number, so try KSVersion first.
   std::wstring version = GetStringValue(L"KSVersion");
-  if (version == L"")
+  if (version.empty())
     version = GetStringValue(L"CFBundleVersion");
   return version;
 }
 
 std::wstring FileVersionInfo::original_filename() {
   return GetStringValue(L"CFBundleName");
 }
 
 std::wstring FileVersionInfo::special_build() {
-  return L"";
+  return std::wstring();
 }
 
 std::wstring FileVersionInfo::last_change() {
   return GetStringValue(L"SVNRevision");
 }
 
 bool FileVersionInfo::is_official_build() {
 #if defined (GOOGLE_CHROME_BUILD)
   return true;
 #else
@@ skipping 11 matching lines @@
       return true;
     }
   }
   return false;
 }
 
 std::wstring FileVersionInfo::GetStringValue(const wchar_t* name) {
   std::wstring str;
   if (GetValue(name, &str))
     return str;
-  return L"";
+  return std::wstring();
 }