Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 243080: Fix several issues with dragging tabs and quickly letting go, including crash... (Closed)

Created:
11 years, 2 months ago by pink (ping after 24hrs)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Fix several issues with dragging tabs and quickly letting go, including crashes because we get mouseDragged "events" after mouseUp, windows that stay transucent, and windows that vanish entirely but stay in the window list. BUG=22266, 13594, 22538 TEST=dragging tabs between windows should still work Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27861

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -15 lines) Patch
M chrome/browser/cocoa/tab_view.mm View 1 10 chunks +45 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pink (ping after 24hrs)
11 years, 2 months ago (2009-10-02 16:17:34 UTC) #1
rohitrao (ping after 24h)
LGTM Did you want to call cancelPreviousPerformRequestsWithTarget in dealloc as well?
11 years, 2 months ago (2009-10-02 16:22:38 UTC) #2
pink (ping after 24hrs)
Done. Thanks for the reminder. New version uploaded. On Fri, Oct 2, 2009 at 12:22 ...
11 years, 2 months ago (2009-10-02 16:32:11 UTC) #3
rohitrao (ping after 24h)
11 years, 2 months ago (2009-10-02 16:56:16 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698