Issue 243068: Make sure my recent changes are represented in the patches....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 243068: Make sure my recent changes are represented in the patches.... (Closed)

Created:
11 years, 2 months ago by Chris Evans

Modified:
9 years, 6 months ago

Reviewers:
Scott Hess - ex-Googler

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make sure my recent changes are represented in the patches. Split out the fts2 changes a little. BUG=NONE TEST=Applied the patches in order to check for mistakes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27787

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1934 lines, -391 lines)			Patch
M	third_party/sqlite/README.chromium	View	1 2	3 chunks	+5 lines, -1 line	0 comments	Download
A	third_party/sqlite/fts2.patch	View		1 chunk	+1929 lines, -0 lines	0 comments	Download
M	third_party/sqlite/misc.patch	View		1 chunk	+0 lines, -390 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Evans

Bookkeeping.... make sure the patches and README are up to date.

11 years, 2 months ago (2009-10-01 22:47:27 UTC) #1

Scott Hess - ex-Googler

lgtm, except the name comment. http://codereview.chromium.org/243068/diff/1001/1002 File third_party/sqlite/README.chromium (right): http://codereview.chromium.org/243068/diff/1001/1002#newcode56 Line 56: fts2-robustness.patch Suggest just ...

11 years, 2 months ago (2009-10-01 22:51:56 UTC) #2

cevans

11 years, 2 months ago (2009-10-01 22:53:47 UTC) #3

On Thu, Oct 1, 2009 at 3:51 PM, <shess@chromium.org> wrote:

> lgtm, except the name comment.
>
>
> http://codereview.chromium.org/243068/diff/1001/1002
> File third_party/sqlite/README.chromium (right):
>
> http://codereview.chromium.org/243068/diff/1001/1002#newcode56
> Line 56: fts2-robustness.patch
> Suggest just calling this fts2.patch, because there is more than just
> corruption-detection changed in there.


Will do - thanks.


>
>
> http://codereview.chromium.org/243068
>

Expand Messages | Collapse Messages