DescriptionDecommits when coallescing spans instead of committing. This results in memory being decommitted very aggressively which can greatly decrease the amount of committed memory in a renderer or the browser process. Based on local tests on windows it causes a perf regression of <2% on the V8 and Dromaeo DOM Core benchmarks and no impact on SunSpider. It decreased the memory footprint of a renderer after running Dromaeo's DOM Core suite from 330MB+ down to <100MB.
Mike Belshe has landed a similar patch in the past, but the behavior was later reverted due to perf concerns. I think this patch is much too aggressive in decommitting memory but given the somewhat out of control memory use of chromium in some cases currently I'd suggest it's better than what we have right now. Over time the decommitting strategy should be tuned to optimize both perf and memory size. Right now we seem to be blowing a lot of memory for not much of a win.
Patch Set 1 #Patch Set 2 : Updates comments #Patch Set 3 : Rebase past the DEFER_DECOMMIT rollback #
Total comments: 4
Messages
Total messages: 7 (0 generated)
|