Fix the stack limits setting API so it is usable.

Fix the stack limits setting API so it is usable.

[Christian Plesner Hansen, 2009-09-30 10:56:34]

http://codereview.chromium.org/242074/diff/1/10
File src/arm/simulator-arm.h (right):

http://codereview.chromium.org/242074/diff/1/10#newcode48
Line 48: #define GENERATED_CODE_STACK_LIMIT(c_limit) \
Can't we get rid of this altogether?

http://codereview.chromium.org/242074/diff/1/2
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/242074/diff/1/2#newcode7935
Line 7935: static const int K = 1024;
I believe K is already defined in globals.

[Christian Plesner Hansen, 2009-09-30 10:56:52]

Whoops, forgot to say: lgtm.

[Erik Corry, 2009-09-30 14:16:12]

On ARM there was an issue that we couldn't set the stack guard before the
simulator was intialized.  So I fixed it to not set the stack limits in the
static constructor, but to wait for the VM to be initialized.  This also means
you can set the stack guard before initializing the VM if you are not using
lockers, which is a nicer API.  New version uploaded.

http://codereview.chromium.org/242074/diff/1/10
File src/arm/simulator-arm.h (right):

http://codereview.chromium.org/242074/diff/1/10#newcode48
Line 48: #define GENERATED_CODE_STACK_LIMIT(c_limit) \
On 2009/09/30 10:56:34, Christian Plesner Hansen wrote:
> Can't we get rid of this altogether?

Unfortunately, due to the dual stack setup of the ARM simulator we can't get rid
of this.  However we can make it a real function instead of a macro.