more missing dependencies (caused by bad dependencies somewhere else)

more missing dependencies (caused by bad dependencies somewhere else)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27355

[M-A Ruel, 2009-09-28 11:57:26]

lgtm

On Sep 27, 2009 7:32 PM, <nsylvain@chromium.org> wrote:

Reviewers: Marc-Antoine Ruel,

Description:
more missing dependencies (caused by bad dependencies somewhere else)


Please review this at http://codereview.chromium.org/242029

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
 M     build/all.gyp


Index: build/all.gyp
===================================================================
--- build/all.gyp       (revision 27354)
+++ build/all.gyp       (working copy)
@@ -155,12 +155,19 @@
            '../chrome/chrome.gyp:url_fetch_test',
            '../chrome/installer/installer.gyp:installer_util_unittests',
            '../chrome/installer/installer.gyp:mini_installer_test',
+            # mini_installer_tests depends on mini_installer. This should
be
+            # defined in installer.gyp.
            '../chrome/installer/mini_installer.gyp:mini_installer',
            '../courgette/courgette.gyp:courgette_unittests',
            '../ipc/ipc.gyp:ipc_tests',
            '../media/media.gyp:media_unittests',
            '../printing/printing.gyp:printing_unittests',

'../webkit/tools/test_shell/test_shell.gyp:npapi_layout_test_plugin',
+            # TODO(nsylvain) ui_tests.exe depends on test_shell_common.
+            # This should:
+            # 1) not be the case. OR.
+            # 2) be expressed in the ui tests dependencies.
+            '../webkit/tools/test_shell/test_shell.gyp:test_shell_common',
            'temp_gyp/googleurl.gyp:googleurl_unittests',
          ],
        },