Issue 242021: Forgot to remove these no-longer important comments in http://src.chromium.or...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 242021: Forgot to remove these no-longer important comments in http://src.chromium.or... (Closed)

Created:
11 years, 2 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Forgot to remove these no-longer important comments in http://src.chromium.org/viewvc/chrome?view=rev&revision=27303. TBR: arv Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27328

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/app/resources/locale_settings.grd	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

11 years, 2 months ago (2009-09-28 16:43:32 UTC) #2

lgtm

On Sat, Sep 26, 2009 at 10:14, <mirandac@chromium.org> wrote:

> Reviewers: arv,
>
> Description:
> Forgot to remove these no-longer important comments in
> http://src.chromium.org/viewvc/chrome?view=rev&revision=27303.
>
> TBR: arv
>
>
> Please review this at http://codereview.chromium.org/242021
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/app/resources/locale_settings.grd
>
>
> Index: chrome/app/resources/locale_settings.grd
> ===================================================================
> --- chrome/app/resources/locale_settings.grd    (revision 27303)
> +++ chrome/app/resources/locale_settings.grd    (working copy)
> @@ -584,13 +584,12 @@
>       </message>
>
>       <!-- The URL for the themes gallery. -->
> -      <!-- TODO(arv): Use GRITLANGCODE -->
>       <message name="IDS_THEMES_GALLERY_URL" translateable="false">
>
>
https://tools.google.com/chrome/intl/[GRITLANGCODE]/themes/index.html<https:/...
>       </message>
> +
>       <!-- The URL for Google Chrome welcome page. This is used for the pre
> -->
>       <!-- populated thumbnails. -->
> -      <!-- TODO(arv): Use GRITLANGCODE -->
>       <message name="IDS_CHROME_WELCOME_URL" translateable="false">
>        
http://www.google.com/chrome/intl/[GRITLANGCODE]/welcome.html<http://www.goog...
>       </message>
>
>
>


-- 
erik

Expand Messages | Collapse Messages