Get rid of LoadAndSpill on ARM since Load() knows whether it is...

Get rid of LoadAndSpill on ARM since Load() knows whether it is
in a spilled scope or not.  Also get rid of some spilled scopes
that we don't need any more.  The generators for the %_ functions,
CodeGenerator::Generate*, are now not spilled by default.  Some
of them (IsObject and related) have been converted to register
allocated operation.

Committed: http://code.google.com/p/v8/source/detail?r=4749

[Søren Thygesen Gjesse, 2010-05-28 10:15:47]

LGTM

http://codereview.chromium.org/2368001/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2368001/diff/1/2#newcode4058
src/arm/codegen-arm.cc:4058: Load(args->at(2));
Isn't SpillAll/AssertIsSpilled needed here? (I don't think %_Log is used when
running our tests though)

http://codereview.chromium.org/2368001/diff/1/2#newcode4519
src/arm/codegen-arm.cc:4519: frame_->SpillAll();
How about moving the SpillAll to CallStub?

[Erik Corry, 2010-05-28 11:24:12]

http://codereview.chromium.org/2368001/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2368001/diff/1/2#newcode4058
src/arm/codegen-arm.cc:4058: Load(args->at(2));
On 2010/05/28 10:15:47, Søren Gjesse wrote:
> Isn't SpillAll/AssertIsSpilled needed here? (I don't think %_Log is used when
> running our tests though)

Well spotted!  I think the real problem here is that a) it isn't tested properly
and b) it should be using VirtualFrame::CallRuntime instead.

http://codereview.chromium.org/2368001/diff/1/2#newcode4519
src/arm/codegen-arm.cc:4519: frame_->SpillAll();
On 2010/05/28 10:15:47, Søren Gjesse wrote:
> How about moving the SpillAll to CallStub?

CallStub is common for the light targets and I want to make some of the stubs
not spill, so for now I will leave it.