Issue 2351002: Better error messages, allow larger-than-needed input when reading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2351002: Better error messages, allow larger-than-needed input when reading. (Closed)

Created:
10 years, 7 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler, gauravsh

CC:
chromium-os-reviews_chromium.org, gauravsh

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

Better error messages, allow larger-than-needed input when reading.

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	src/platform/vboot_reference/misclibs/file_keys.c	View		2 chunks	+5 lines, -5 lines	0 comments	Download
	M	src/platform/vboot_reference/vkernel/kernel_image.c	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gauravsh

LGTM http://codereview.chromium.org/2351002/diff/1/3 File src/platform/vboot_reference/vkernel/kernel_image.c (right): http://codereview.chromium.org/2351002/diff/1/3#newcode179 src/platform/vboot_reference/vkernel/kernel_image.c:179: if(st.overrun) { add a comment here that underruns ...

10 years, 7 months ago (2010-05-28 07:22:43 UTC) #2

LGTM

Expand Messages | Collapse Messages