Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: src/platform/vboot_reference/vkernel/kernel_image.c

Issue 2351002: Better error messages, allow larger-than-needed input when reading. (Closed) Base URL: ssh://git@chromiumos-git/chromeos
Patch Set: Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/platform/vboot_reference/misclibs/file_keys.c ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform/vboot_reference/vkernel/kernel_image.c
diff --git a/src/platform/vboot_reference/vkernel/kernel_image.c b/src/platform/vboot_reference/vkernel/kernel_image.c
index d22942ace9082ac71f4dce37d7f51c3361485e74..ff0936a99a960001336655ed76135cdfbe555c5d 100644
--- a/src/platform/vboot_reference/vkernel/kernel_image.c
+++ b/src/platform/vboot_reference/vkernel/kernel_image.c
@@ -176,7 +176,7 @@ KernelImage* ReadKernelImage(const char* input_file) {
image->kernel_data = (uint8_t*) Malloc(image->kernel_len);
StatefulMemcpy(&st, image->kernel_data, image->kernel_len);
- if(st.overrun || st.remaining_len != 0) { /* Overrun or underrun. */
+ if(st.overrun) {
gauravsh 2010/05/28 07:22:43 add a comment here that underruns are ok here?
Free(kernel_buf);
return NULL;
}
« no previous file with comments | « src/platform/vboot_reference/misclibs/file_keys.c ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698