Fix conflicts between accelerator keys and HTML DOM accesskeys....

chrome/browser/gtk/browser_window_gtk.cc

Index: chrome/browser/gtk/browser_window_gtk.cc
===================================================================
--- chrome/browser/gtk/browser_window_gtk.cc	(revision 29767)
+++ chrome/browser/gtk/browser_window_gtk.cc	(working copy)
@@ -593,7 +593,7 @@
   }
 }
 
-void BrowserWindowGtk::HandleKeyboardEvent(GdkEventKey* event) {
+bool BrowserWindowGtk::HandleKeyboardEvent(GdkEventKey* event) {
   // Handles a key event in following sequence:
   // 1. Our special key accelerators, such as ctrl-tab, etc.
   // 2. Gtk mnemonics and accelerators.
@@ -603,8 +603,9 @@
   // gtk_window_activate_key() takes care of it automatically.
   if (!HandleCustomAccelerator(event->keyval, GdkModifierType(event->state),
                                browser_.get())) {
-    gtk_window_activate_key(window_, event);
+    return gtk_window_activate_key(window_, event);
   }
+  return true;

[Nico, 2009/10/24 02:31:10]

This would be easier to understand if it went like

  if (HandleC…)
    return true;
  return gtk_wind…

[James Su, 2009/10/24 10:53:48]

Good point. I'll change it in an upcoming CL.

On 2009/10/24 02:31:10, Nico wrote:

 }
 
 gboolean BrowserWindowGtk::OnCustomFrameExpose(GtkWidget* widget,