Fix conflicts between accelerator keys and HTML DOM accesskeys....

chrome/browser/gtk/browser_window_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/browser_window_gtk.h"
 
 #include <gdk/gdkkeysyms.h>
 #include <X11/XF86keysym.h>
 
 #include <string>
@@ skipping 575 matching lines @@
   ActiveWindowWatcherX::RemoveObserver(this);
 
   browser_->tabstrip_model()->RemoveObserver(this);
 
   if (frame_cursor_) {
     gdk_cursor_unref(frame_cursor_);
     frame_cursor_ = NULL;
   }
 }
 
-void BrowserWindowGtk::HandleKeyboardEvent(GdkEventKey* event) {
+bool BrowserWindowGtk::HandleKeyboardEvent(GdkEventKey* event) {
   // Handles a key event in following sequence:
   // 1. Our special key accelerators, such as ctrl-tab, etc.
   // 2. Gtk mnemonics and accelerators.
   // This sequence matches the default key press handler of GtkWindow.
   //
   // It's not necessary to care about the keyboard layout, as
   // gtk_window_activate_key() takes care of it automatically.
   if (!HandleCustomAccelerator(event->keyval, GdkModifierType(event->state),
                                browser_.get())) {
-    gtk_window_activate_key(window_, event);
+    return gtk_window_activate_key(window_, event);
   }
+  return true;

[Nico, 2009/10/24 02:31:10]

This would be easier to understand if it went like

  if (HandleC…)
    return true;
  return gtk_wind…

[James Su, 2009/10/24 10:53:48]

Good point. I'll change it in an upcoming CL.

On 2009/10/24 02:31:10, Nico wrote:

 }
 
 gboolean BrowserWindowGtk::OnCustomFrameExpose(GtkWidget* widget,
                                                GdkEventExpose* event,
                                                BrowserWindowGtk* window) {
   GtkThemeProvider* theme_provider = GtkThemeProvider::GetFrom(
       window->browser()->profile());
 
   // Draw the default background.
   cairo_t* cr = gdk_cairo_create(GDK_DRAWABLE(widget->window));
@@ skipping 1657 matching lines @@
   // are taken from the WMs' source code.
   return (wm_name == "Blackbox" ||
           wm_name == "compiz" ||
           wm_name == "e16" ||  // Enlightenment DR16
           wm_name == "KWin" ||
           wm_name == "Metacity" ||
           wm_name == "Mutter" ||
           wm_name == "Openbox" ||
           wm_name == "Xfwm4");
 }