Issue 2327001: VerifyKernelHeader() fills a KernelImage*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2327001: VerifyKernelHeader() fills a KernelImage* (Closed)

Created:
10 years, 7 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
Bill Richardson

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org/chromiumos

Visibility:
Public.

Description

VerifyKernelHeader() fills a KernelImage* Rather than copying individual fields. More suitable for use in LoadKernel(). Added StatefulSkip(), so that fields in the input stream can be skipped more cleanly.

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -32 lines)			Patch
M	src/platform/vboot_reference/vboot_firmware/include/kernel_image_fw.h	View	1 chunk	+7 lines, -4 lines	0 comments	Download
M	src/platform/vboot_reference/vboot_firmware/lib/include/stateful_util.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/vboot_firmware/lib/kernel_image_fw.c	View	2 chunks	+58 lines, -27 lines	0 comments	Download
M	src/platform/vboot_reference/vboot_firmware/lib/stateful_util.c	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/vboot_firmware/linktest/main.c	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages