Preliminary fixes to enable link dependent objects....

Preliminary fixes to enable link dependent objects.

BUG=22926
TEST=still builds

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27112

[Nicolas Sylvain, 2009-09-24 18:45:28]

I had to make a bunch of those changes too when I was trying to split chrome in
multiple dlls. I guess i should have checked in before! 

I LGTM everything but the gyp files, because I really don't know why you remove
files. Are they really not needed? On all platforms? 

If you think the GYP files are ok, then i'm ok with the change.

[M-A Ruel, 2009-09-24 18:51:09]

installer.gyp:
these files are already in common and installer depends on common anyway.

tcmalloc.gyp:
raw_printer are actually used so they must not be removed.

test_shell.gyp:
winmm.lib is used by the plugin in some circonstances.

[M-A Ruel, 2009-09-24 19:08:39]

On Thu, Sep 24, 2009 at 2:58 PM, Rahul Kuchhal <kuchhal@chromium.org> wrote:
>> installer.gyp:
>> these files are already in common and installer depends on common anyway.
>
> The files are part of installer_util project which I do not think depends on
> common.

You are free to *think* so. But I can assure you the fact. :)

http://codereview.chromium.org/231020/diff/3002/3006?context=&column_width=80

Search for './chrome.gyp:common'

[kuchhal, 2009-09-24 19:22:13]

Hmm.. originally it didn't. Now after gypification I can see that dependency
in the gyp file but if I check the generated chrome.sln file or Visual
Studio Project Dependencies I do not see it.

On Thu, Sep 24, 2009 at 12:08 PM, <maruel@chromium.org> wrote:

> On Thu, Sep 24, 2009 at 2:58 PM, Rahul Kuchhal <kuchhal@chromium.org>
> wrote:
>
>> installer.gyp:
>>> these files are already in common and installer depends on common anyway.
>>>
>>
>  The files are part of installer_util project which I do not think depends
>> on
>> common.
>>
>
> You are free to *think* so. But I can assure you the fact. :)
>
>
> http://codereview.chromium.org/231020/diff/3002/3006?context=&column_width=80
>
> Search for './chrome.gyp:common'
>
>
> http://codereview.chromium.org/231020
>

[M-A Ruel, 2009-09-24 19:24:23]

On 2009/09/24 19:22:13, kuchhal wrote:
> Hmm.. originally it didn't. Now after gypification I can see that dependency
> in the gyp file but if I check the generated chrome.sln file or Visual
> Studio Project Dependencies I do not see it.

That's not the way gyp works. Only the actual binary projects will depend on the
static lib. Take installer_util_unittests for instance.

So do you still have an objection?