Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 230001: Remove quotes around "44" when checking gcc_version in v8.gyp.... (Closed)

Created:
11 years, 3 months ago by Craig
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
v8-dev
Visibility:
Public.

Description

Remove quotes around "44" when checking gcc_version in v8.gyp. This is necessary due to a recent change in gyp that turns a numeric string value in a gyp variable into an integer.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gyp/v8.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Craig
Mark: can you comment on whether I'm interpreting the latest gyp behavior correctly please? V8 ...
11 years, 3 months ago (2009-09-23 14:27:32 UTC) #1
Craig
11 years, 3 months ago (2009-09-23 15:37:17 UTC) #2
Mads has landed this in r2965 in v8 and rolled DEPS in r26918 in chromium.

Thanks guys!

(will close)

Powered by Google App Engine
This is Rietveld 408576698