Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: tools/gyp/v8.gyp

Issue 230001: Remove quotes around "44" when checking gcc_version in v8.gyp.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2009 the V8 project authors. All rights reserved. 1 # Copyright 2009 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 'conditions': [ 80 'conditions': [
81 ['OS=="linux"', { 81 ['OS=="linux"', {
82 'cflags!': [ 82 'cflags!': [
83 '-O2', 83 '-O2',
84 ], 84 ],
85 'cflags': [ 85 'cflags': [
86 '-fomit-frame-pointer', 86 '-fomit-frame-pointer',
87 '-O3', 87 '-O3',
88 ], 88 ],
89 'conditions': [ 89 'conditions': [
90 [ 'gcc_version=="44"', { 90 [ 'gcc_version==44', {
91 'cflags': [ 91 'cflags': [
92 # Avoid gcc 4.4 strict aliasing issues in dtoa.c 92 # Avoid gcc 4.4 strict aliasing issues in dtoa.c
93 '-fno-strict-aliasing', 93 '-fno-strict-aliasing',
94 # Avoid crashes with gcc 4.4 in the v8 test suite. 94 # Avoid crashes with gcc 4.4 in the v8 test suite.
95 '-fno-tree-vrp', 95 '-fno-tree-vrp',
96 ], 96 ],
97 }], 97 }],
98 ], 98 ],
99 }], 99 }],
100 ['OS=="mac"', { 100 ['OS=="mac"', {
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
570 ], 570 ],
571 'conditions': [ 571 'conditions': [
572 [ 'OS=="win"', { 572 [ 'OS=="win"', {
573 # This could be gotten by not setting chromium_code, if that's OK. 573 # This could be gotten by not setting chromium_code, if that's OK.
574 'defines': ['_CRT_SECURE_NO_WARNINGS'], 574 'defines': ['_CRT_SECURE_NO_WARNINGS'],
575 }], 575 }],
576 ], 576 ],
577 }, 577 },
578 ], 578 ],
579 } 579 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698