Issue 2279005: Move assertions to not take case to check that it's safe to omit CheckPrototypes in this case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2279005: Move assertions to not take case to check that it's safe to omit CheckPrototypes in this case. (Closed)

Created:
10 years, 7 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Move assertions to not take case to check that it's safe to omit CheckPrototypes in this case. Committed: http://code.google.com/p/v8/source/detail?r=4740

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -3 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

antonm

Søren, fix a stupid check: ASSERTs should have checked that it's safe to omit CheckPrototypes ...

10 years, 7 months ago (2010-05-27 10:59:24 UTC) #1

LGTM