Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Side by Side Diff: src/x64/stub-cache-x64.cc

Issue 2279005: Move assertions to not take case to check that it's safe to omit CheckPrototypes in this case. (Closed)
Patch Set: Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 745 matching lines...) Expand 10 before | Expand all | Expand 10 after
756 756
757 // Interceptor returned nothing for this property. Try to use cached 757 // Interceptor returned nothing for this property. Try to use cached
758 // constant function. 758 // constant function.
759 759
760 // Check that the maps from interceptor's holder to constant function's 760 // Check that the maps from interceptor's holder to constant function's
761 // holder haven't changed and thus we can use cached constant function. 761 // holder haven't changed and thus we can use cached constant function.
762 if (interceptor_holder != lookup->holder()) { 762 if (interceptor_holder != lookup->holder()) {
763 stub_compiler_->CheckPrototypes(interceptor_holder, receiver, 763 stub_compiler_->CheckPrototypes(interceptor_holder, receiver,
764 lookup->holder(), scratch1, 764 lookup->holder(), scratch1,
765 scratch2, name, depth2, miss); 765 scratch2, name, depth2, miss);
766 } else {
766 // CheckPrototypes has a side effect of fetching a 'holder' 767 // CheckPrototypes has a side effect of fetching a 'holder'
767 // for API (object which is instanceof for the signature). It's 768 // for API (object which is instanceof for the signature). It's
768 // safe to omit it here, as if present, it should be fetched 769 // safe to omit it here, as if present, it should be fetched
769 // by the previous CheckPrototypes. 770 // by the previous CheckPrototypes.
770 ASSERT((depth2 == kInvalidProtoDepth) || (depth1 != kInvalidProtoDepth)); 771 ASSERT(depth2 == kInvalidProtoDepth);
771 } 772 }
772 773
773 // Invoke function. 774 // Invoke function.
774 if (can_do_fast_api_call) { 775 if (can_do_fast_api_call) {
775 GenerateFastApiCall(masm, optimization, arguments_.immediate()); 776 GenerateFastApiCall(masm, optimization, arguments_.immediate());
776 } else { 777 } else {
777 __ InvokeFunction(optimization.constant_function(), arguments_, 778 __ InvokeFunction(optimization.constant_function(), arguments_,
778 JUMP_FUNCTION); 779 JUMP_FUNCTION);
779 } 780 }
780 781
(...skipping 1619 matching lines...) Expand 10 before | Expand all | Expand 10 after
2400 // Return the generated code. 2401 // Return the generated code.
2401 return GetCode(); 2402 return GetCode();
2402 } 2403 }
2403 2404
2404 2405
2405 #undef __ 2406 #undef __
2406 2407
2407 } } // namespace v8::internal 2408 } } // namespace v8::internal
2408 2409
2409 #endif // V8_TARGET_ARCH_X64 2410 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698