test_shell_gtk: applies the same change as test_shell_win from http://codereview.chromium.org/27109

test_shell_gtk: applies the same change as test_shell_win from http://codereview.chromium.org/27109

TEST=everything should still be green, Geolocation should finally pass.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48478

[bulach, 2010-05-27 11:35:20]

Hi sky, agl,

I'm applying sky's change to gtk here: without it, geolocation layout tests will
fail.

Would you mind taking a quick look? bots seem to be happy and green :) but I'm
not sure if there was an explicit reason not to have this change in gtk.

Thanks!

[agl, 2010-05-27 14:30:40]

http://codereview.chromium.org/2279002/diff/2001/3001
File webkit/tools/test_shell/test_shell_gtk.cc (right):

http://codereview.chromium.org/2279002/diff/2001/3001#newcode524
webkit/tools/test_shell/test_shell_gtk.cc:524: window =
*(TestShell::windowList()->begin());
in CL 27109, grabbing the window again occurs before ResetTestController. I
don't really know what's going on here, but if there's a reason that Windows and
Linux differ in this respect then it should probably be commented.

[bulach, 2010-05-27 14:42:26]

thanks agl!

explanation inline below:

http://codereview.chromium.org/2279002/diff/2001/3001
File webkit/tools/test_shell/test_shell_gtk.cc (right):

http://codereview.chromium.org/2279002/diff/2001/3001#newcode524
webkit/tools/test_shell/test_shell_gtk.cc:524: window =
*(TestShell::windowList()->begin());
On 2010/05/27 14:30:40, agl wrote:
> in CL 27109, grabbing the window again occurs before ResetTestController. I
> don't really know what's going on here, but if there's a reason that Windows
and
> Linux differ in this respect then it should probably be commented.

ops, sorry, I should've clarified: sky addressed tony's comments on CL 27109,
this is what was actually submitted:

http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_...


so this change is identical to windows.

[agl, 2010-05-27 14:44:34]

LGTM

[sky, 2010-05-27 15:43:37]

LGTM