Issue 27109: Fixes bug in test shell. We were invoking ResetTestController before...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27109: Fixes bug in test shell. We were invoking ResetTestController before... (Closed)

Created:
11 years, 10 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
tony, tc

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes bug in test shell. We were invoking ResetTestController before StopLoading. This is problematic because StopLayout may end up changing state in the layout test controller (the frozen status of the WorkQueue in this case). I've changed it to reset the status after invoking StopLoading. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10315

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
	M	webkit/tools/layout_tests/test_lists/tests_fixable.txt	View		2 chunks	+2 lines, -5 lines	0 comments	Download
	M	webkit/tools/test_shell/test_shell_win.cc	View		2 chunks	+5 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM http://codereview.chromium.org/27109/diff/1/3 File webkit/tools/test_shell/test_shell_win.cc (right): http://codereview.chromium.org/27109/diff/1/3#newcode235 Line 235: hwnd = *(TestShell::windowList()->begin()); Nit: Should we move ...

11 years, 10 months ago (2009-02-24 23:33:45 UTC) #2

sky

11 years, 10 months ago (2009-02-25 00:26:14 UTC) #3

Done, and I ran all the tests again to make sure it didn't screw anything up.

Expand Messages | Collapse Messages