Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Issue 2271001: Fix issue 720 making Object.defineProperty handle existing writable flags cor... (Closed)

Created:
10 years, 7 months ago by Rico
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Fix issue 720 making Object.defineProperty handle existing writable flags correctly. The existing version will overwrite the existing writable flag with false even in the case where no new value is given and the existing writable flag is true. The reason for the issue is that there is no check to see if the provided descriptor actually has a writable attribute. This causes us to use the default value (false) even in the case where nothing was provided. In addition, the existing tests makes wrong assumptions (that writable is always set to false if not provided) and has been changed to follow the specification. Committed: http://code.google.com/p/v8/source/detail?r=4720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M src/v8natives.js View 1 chunk +7 lines, -1 line 0 comments Download
M test/mjsunit/object-define-property.js View 2 chunks +2 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-720.js View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Rico
10 years, 7 months ago (2010-05-26 07:52:28 UTC) #1
Erik Corry
10 years, 7 months ago (2010-05-26 08:28:34 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698