src/v8natives.js - Issue 2271001: Fix issue 720 making Object.defineProperty handle existing writable flags cor...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8natives.js

Issue 2271001: Fix issue 720 making Object.defineProperty handle existing writable flags cor... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/v8natives.js

===================================================================

--- src/v8natives.js (revision 4711)

+++ src/v8natives.js (working copy)

@@ -604,7 +604,13 @@

flag |= DONT_DELETE;

if (IsDataDescriptor(desc) || IsGenericDescriptor(desc)) {

- flag |= desc.isWritable() ? 0 : READ_ONLY;

+ if (desc.hasWritable()) {

+ flag |= desc.isWritable() ? 0 : READ_ONLY;

+ } else if (!IS_UNDEFINED(current)) {

+ flag |= current.isWritable() ? 0 : READ_ONLY;

+ } else {

+ flag |= READ_ONLY;

+ }

%DefineOrRedefineDataProperty(obj, p, desc.getValue(), flag);

} else {

if (desc.hasGetter() && IS_FUNCTION(desc.getGet())) {

« no previous file with comments | « no previous file | test/mjsunit/object-define-property.js » ('j') | no next file with comments »