Issue 227013: Remove unused tab_contents variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 227013: Remove unused tab_contents variable. (Closed)

Created:
11 years, 3 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Remove unused tab_contents variable. CID=6204 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27106

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome/browser/automation/automation_provider.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 3 months ago (2009-09-24 03:26:11 UTC) #2

LGTM

On Wed, Sep 23, 2009 at 7:32 PM,  <mattm@chromium.org> wrote:
> Reviewers: brettw,
>
> Description:
> Remove unused tab_contents variable.
>
> CID=3D6204
> BUG=3Dnone
> TEST=3Dnone
>
> Please review this at http://codereview.chromium.org/227013
>
> Affected files:
> =A0M chrome/browser/automation/automation_provider.cc
>
>
> Index: chrome/browser/automation/automation_provider.cc
> diff --git a/chrome/browser/automation/automation_provider.cc
> b/chrome/browser/automation/automation_provider.cc
> index
> cfd6eac108adbe5c1b69d48dc65271263a8682cc..65dae1db0b61de9abe8380a1cebca9c=
f9ebf41ef
> 100644
> --- a/chrome/browser/automation/automation_provider.cc
> +++ b/chrome/browser/automation/automation_provider.cc
> @@ -1850,7 +1850,6 @@ void AutomationProvider::OverrideEncoding(int
> tab_handle,
> =A0 =A0 DCHECK(browser);
>
> =A0 =A0 if (browser->command_updater()->IsCommandEnabled(IDC_ENCODING_MEN=
U)) {
> - =A0 =A0 =A0TabContents* tab_contents =3D nav->tab_contents();
> =A0 =A0 =A0 int selected_encoding_id =3D
>
> CharacterEncoding::GetCommandIdByCanonicalEncodingName(encoding_name);
> =A0 =A0 =A0 if (selected_encoding_id) {
>
>
>

Expand Messages | Collapse Messages