Issue 2263005: Linux: use web application meta tags for application shortcuts where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2263005: Linux: use web application meta tags for application shortcuts where possible. (Closed)

Created:
10 years, 7 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
tony, brettw

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Linux: use web application meta tags for application shortcuts where possible. TEST=none BUG=45124 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48491

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -16 lines)			Patch
	M	chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h	View		1 chunk	+0 lines, -9 lines	0 comments	Download
	M	chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc	View	1	3 chunks	+2 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

Paweł Hajdan Jr.

This change has still missing support for description and icon meta tags, but they would ...

10 years, 7 months ago (2010-05-26 19:36:15 UTC) #1

brettw

The Windows version uses web_app::GetShortcutInfoForTab. It seems like this function is cross-platform. Should you be ...

10 years, 7 months ago (2010-05-26 20:51:55 UTC) #2

Paweł Hajdan Jr.

Sure, switched to it now. By the way, I've filed http://code.google.com/p/chromium/issues/detail?id=45204 to clean up the ...

10 years, 7 months ago (2010-05-27 09:19:14 UTC) #3

LGTM