Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Unified Diff: chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc

Issue 2263005: Linux: use web application meta tags for application shortcuts where possible. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: use web_app Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
diff --git a/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc b/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
index 0bf2cb99ef2e91df03a23880cca6cd105aa11fe4..98596462396209722fd4a51b4aaced6a6cf6807a 100644
--- a/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
+++ b/chrome/browser/gtk/create_application_shortcuts_dialog_gtk.cc
@@ -13,6 +13,7 @@
#include "chrome/browser/shell_integration.h"
#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/browser/tab_contents/tab_contents_delegate.h"
+#include "chrome/browser/web_applications/web_app.h"
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
#include "grit/locale_settings.h"
@@ -27,10 +28,6 @@ CreateApplicationShortcutsDialogGtk::CreateApplicationShortcutsDialogGtk(
GtkWindow* parent,
TabContents* tab_contents)
: tab_contents_(tab_contents),
- url_(tab_contents->GetURL()),
- title_(tab_contents->GetTitle()),
- favicon_(tab_contents->FavIconIsValid() ? tab_contents->GetFavIcon() :
- SkBitmap()),
error_dialog_(NULL) {
DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
@@ -98,9 +95,7 @@ void CreateApplicationShortcutsDialogGtk::OnCreateDialogResponse(
if (response == GTK_RESPONSE_ACCEPT) {
ShellIntegration::ShortcutInfo shortcut_info;
- shortcut_info.url = url_;
- shortcut_info.title = title_;
- shortcut_info.favicon = favicon_;
+ web_app::GetShortcutInfoForTab(tab_contents_, &shortcut_info);
shortcut_info.create_on_desktop =
gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(desktop_checkbox_));
shortcut_info.create_in_applications_menu =
« no previous file with comments | « chrome/browser/gtk/create_application_shortcuts_dialog_gtk.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698