Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/chrome_tests.gypi

Issue 2262001: Fix Linux coverage which doesn't like a gyp 'inputs' to contain non-files.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_tests.gypi
===================================================================
--- chrome/chrome_tests.gypi (revision 48246)
+++ chrome/chrome_tests.gypi (working copy)
@@ -2420,7 +2420,23 @@
# src/chrome.
'message': 'Compiling coverage bundles.',
# MSVS must have an input file and an output file.
- 'inputs': [ '<@(_dependencies)' ],
+ #
+ # TODO(jrg):
+ # Technically I want inputs to be the list of
+ # executables created in <@(_dependencies) but use of
+ # that variable lists the dep by dep name, not their
+ # output executable name.
+ # Is there a better way to force this action to run, always?
+ #
+ # If a test bundle is added to this coverage_build target it
+ # necessarily means this file (chrome_tests.gypi) is changed,
+ # so the action is run (coverage_bundles.py is generated).
+ # Exceptions to that rule are theoretically possible
+ # (e.g. re-gyp with a GYP_DEFINES set).
+ # Else it's the same list of bundles as last time. They are
+ # built (since on the deps list) but the action may not run.
+ # For now, things work, but it's less than ideal.
+ 'inputs': [ 'chrome_tests.gypi' ],
'outputs': [ '<(PRODUCT_DIR)/coverage_bundles.py' ],
'action_name': 'coverage_build',
'action': [ 'python', '-c',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698