Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: chrome/chrome_tests.gypi

Issue 2262001: Fix Linux coverage which doesn't like a gyp 'inputs' to contain non-files.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables' : { 6 'variables' : {
7 'browser_tests_sources_views_specific': [ 7 'browser_tests_sources_views_specific': [
8 'browser/extensions/browser_action_test_util_views.cc', 8 'browser/extensions/browser_action_test_util_views.cc',
9 'browser/views/browser_actions_container_browsertest.cc', 9 'browser/views/browser_actions_container_browsertest.cc',
10 ], 10 ],
(...skipping 2402 matching lines...) Expand 10 before | Expand all | Expand 10 after
2413 # Placeholder; empty for now. 2413 # Placeholder; empty for now.
2414 ]}], 2414 ]}],
2415 ], # 'conditions' 2415 ], # 'conditions'
2416 'actions': [ 2416 'actions': [
2417 { 2417 {
2418 # 'message' for Linux/scons in particular. Scons 2418 # 'message' for Linux/scons in particular. Scons
2419 # requires the 'coverage' target be run from within 2419 # requires the 'coverage' target be run from within
2420 # src/chrome. 2420 # src/chrome.
2421 'message': 'Compiling coverage bundles.', 2421 'message': 'Compiling coverage bundles.',
2422 # MSVS must have an input file and an output file. 2422 # MSVS must have an input file and an output file.
2423 'inputs': [ '<@(_dependencies)' ], 2423 #
2424 # TODO(jrg):
2425 # Technically I want inputs to be the list of
2426 # executables created in <@(_dependencies) but use of
2427 # that variable lists the dep by dep name, not their
2428 # output executable name.
2429 # Is there a better way to force this action to run, always?
2430 #
2431 # If a test bundle is added to this coverage_build target it
2432 # necessarily means this file (chrome_tests.gypi) is changed,
2433 # so the action is run (coverage_bundles.py is generated).
2434 # Exceptions to that rule are theoretically possible
2435 # (e.g. re-gyp with a GYP_DEFINES set).
2436 # Else it's the same list of bundles as last time. They are
2437 # built (since on the deps list) but the action may not run.
2438 # For now, things work, but it's less than ideal.
2439 'inputs': [ 'chrome_tests.gypi' ],
2424 'outputs': [ '<(PRODUCT_DIR)/coverage_bundles.py' ], 2440 'outputs': [ '<(PRODUCT_DIR)/coverage_bundles.py' ],
2425 'action_name': 'coverage_build', 2441 'action_name': 'coverage_build',
2426 'action': [ 'python', '-c', 2442 'action': [ 'python', '-c',
2427 'import os; ' 2443 'import os; '
2428 'f = open(' \ 2444 'f = open(' \
2429 '\'<(PRODUCT_DIR)\' + os.path.sep + ' \ 2445 '\'<(PRODUCT_DIR)\' + os.path.sep + ' \
2430 '\'coverage_bundles.py\'' \ 2446 '\'coverage_bundles.py\'' \
2431 ', \'w\'); ' \ 2447 ', \'w\'); ' \
2432 'deplist = \'' \ 2448 'deplist = \'' \
2433 '<@(_dependencies)' \ 2449 '<@(_dependencies)' \
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
2478 ] 2494 ]
2479 }], # 'coverage!=0' 2495 }], # 'coverage!=0'
2480 ], # 'conditions' 2496 ], # 'conditions'
2481 } 2497 }
2482 2498
2483 # Local Variables: 2499 # Local Variables:
2484 # tab-width:2 2500 # tab-width:2
2485 # indent-tabs-mode:nil 2501 # indent-tabs-mode:nil
2486 # End: 2502 # End:
2487 # vim: set expandtab tabstop=2 shiftwidth=2: 2503 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698