Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2253001: Revert 48186, 48196, 48198 (Closed)

Created:
10 years, 7 months ago by rafaelw
Modified:
9 years, 7 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews, ncarter (slow), idana, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, cbentzel+watch_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., kuchhal, darin-cc_chromium.org, amit, tim (not reviewing)
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Revert "Another dependency the bbot missed!!!" This reverts commit 161f7fd3bdd425167af9fe26fdc5373a2ff44c98. Revert "Missed a file as part of checkin for r48186" This reverts commit cff86beba5938209393a6c3bccced62a7f3ff36b. Revert "Enable warning 4389 as an error on windows builds. This will make" This reverts commit c78936bcfc65b98edf288191d927a495b0364621. TBR=mbelshe Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -167 lines) Patch
M app/os_exchange_data_provider_win.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M app/win/window_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/crypto/scoped_capi_types.h View 1 chunk +1 line, -1 line 0 comments Download
M base/event_trace_consumer_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/event_trace_controller_win_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M base/event_trace_provider_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/file_util_win.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M base/iat_patch.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/lock_impl_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/scoped_bstr_win_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/thread_local.h View 2 chunks +2 lines, -2 lines 0 comments Download
M build/common.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/app/chrome_dll_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/ui_controls_win.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_uitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/importer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/syncable/syncable.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/views/select_profile_dialog.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/installer/util/l10n_string_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_active_document.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome_frame/chrome_frame_activex.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome_frame/chrome_launcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/function_stub_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome_frame/html_utils.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/exception_barrier_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/html_util_unittests.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/util_unittests.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/urlmon_url_request.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M gfx/icon_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
net/base/listen_socket_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/network_change_notifier_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/tcp_client_socket_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/dump_cache/cache_dumper.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M net/tools/dump_cache/upgrade.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M sandbox/src/file_policy_test.cc View 5 chunks +16 lines, -16 lines 0 comments Download
sandbox/src/interception_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M sandbox/src/job_unittest.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M sandbox/src/restricted_token_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M sandbox/src/win_utils_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M views/controls/table/table_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/default_plugin/plugin_database_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698