net/socket/tcp_client_socket_win.cc - Issue 2253001: Revert 48186, 48196, 48198

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/tcp_client_socket_win.cc

Issue 2253001: Revert 48186, 48196, 48198 (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/tcp_client_socket_win.cc

diff --git a/net/socket/tcp_client_socket_win.cc b/net/socket/tcp_client_socket_win.cc

index c66399210191d1c817f71f1c9fa23797cc05edf0..7c6f41d7b009d517b16a0e925ca96c9136af153c 100644

--- a/net/socket/tcp_client_socket_win.cc

+++ b/net/socket/tcp_client_socket_win.cc

@@ -508,7 +508,7 @@ int TCPClientSocketWin::Read(IOBuffer* buf,

core_->read_buffer_.buf = buf->data();

// TODO(wtc): Remove the CHECK after enough testing.

- CHECK_EQ(static_cast<DWORD>(WAIT_TIMEOUT),

+ CHECK_EQ(WAIT_TIMEOUT,

WaitForSingleObject(core_->read_overlapped_.hEvent, 0));

DWORD num, flags = 0;

int rv = WSARecv(socket_, &core_->read_buffer_, 1, &num, &flags,

@@ -558,7 +558,7 @@ int TCPClientSocketWin::Write(IOBuffer* buf,

core_->write_buffer_length_ = buf_len;

// TODO(wtc): Remove the CHECK after enough testing.

- CHECK_EQ(static_cast<DWORD>(WAIT_TIMEOUT),

+ CHECK_EQ(WAIT_TIMEOUT,

WaitForSingleObject(core_->write_overlapped_.hEvent, 0));

DWORD num;

int rv = WSASend(socket_, &core_->write_buffer_, 1, &num, 0,

« no previous file with comments | « net/base/network_change_notifier_win.cc ('k') | net/tools/dump_cache/cache_dumper.cc » ('j') | no next file with comments »