Issue 225023: Another draft of the overview. Made related changes to the content scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 225023: Another draft of the overview. Made related changes to the content scripts (Closed)

Created:
11 years, 3 months ago by Kathy Walrath

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Another draft of the overview, now with figures. Made related changes to the background pages and content scripts pages. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27121

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+243 lines, -364 lines)			Patch
M	chrome/common/extensions/docs/background_pages.html	View	1	1 chunk	+13 lines, -1 line	0 comments	Download
M	chrome/common/extensions/docs/content_scripts.html	View	1	2 chunks	+8 lines, -5 lines	0 comments	Download
A	chrome/common/extensions/docs/images/arch-1.gif	View		Binary file		0 comments	Download
A	chrome/common/extensions/docs/images/arch-2.gif	View		Binary file		0 comments	Download
A	chrome/common/extensions/docs/images/arch-3.gif	View		Binary file		0 comments	Download
A	chrome/common/extensions/docs/images/arch-cs.gif	View		Binary file		0 comments	Download
M	chrome/common/extensions/docs/overview.html	View	1	9 chunks	+101 lines, -176 lines	0 comments	Download
MM	chrome/common/extensions/docs/static/background_pages.html	View		1 chunk	+13 lines, -1 line	0 comments	Download
M	chrome/common/extensions/docs/static/content_scripts.html	View		2 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/docs/static/overview.html	View		8 chunks	+100 lines, -176 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

lgtm http://codereview.chromium.org/225023/diff/1/9 File chrome/common/extensions/docs/content_scripts.html (right): http://codereview.chromium.org/225023/diff/1/9#newcode658 Line 658: #TEST_TIMED_OUT Whoops. Try rerunning?

11 years, 3 months ago (2009-09-24 18:35:45 UTC) #2

Kathy Walrath

11 years, 3 months ago (2009-09-24 18:42:34 UTC) #3

Whoops! I'll fix that.

-k-

On Thu, Sep 24, 2009 at 11:35 AM,  <aa@chromium.org> wrote:
> lgtm
>
>
> http://codereview.chromium.org/225023/diff/1/9
> File chrome/common/extensions/docs/content_scripts.html (right):
>
> http://codereview.chromium.org/225023/diff/1/9#newcode658
> Line 658: #TEST_TIMED_OUT
> Whoops. Try rerunning?
>
> http://codereview.chromium.org/225023
>

Expand Messages | Collapse Messages

Issue 225023: Another draft of the overview. Made related changes to the content scripts (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages