Issue 225014: Don't ellpsize the Other Bookmarks button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 225014: Don't ellpsize the Other Bookmarks button. (Closed)

Created:
11 years, 3 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GTK: Don't ellipsize the Other Bookmarks button. BUG=22788 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27041

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	chrome/browser/gtk/bookmark_utils_gtk.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

11 years, 3 months ago (2009-09-23 19:30:25 UTC) #2

Hilarious. LGTM.

On Wed, Sep 23, 2009 at 11:42 AM,  <estade@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> Don't ellpsize the Other Bookmarks button.
>
> BUG=3D22788
>
>
> Please review this at http://codereview.chromium.org/225014
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/browser/gtk/bookmark_utils_gtk.cc
>
>
> Index: chrome/browser/gtk/bookmark_utils_gtk.cc
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/gtk/bookmark_utils_gtk.cc =A0 =A0(revision 26890)
> +++ chrome/browser/gtk/bookmark_utils_gtk.cc =A0 =A0(working copy)
> @@ -124,8 +124,13 @@
> =A0 std::string label_string =3D WideToUTF8(node->GetTitle());
> =A0 if (!label_string.empty()) {
> =A0 =A0 GtkWidget* label =3D gtk_label_new(label_string.c_str());
> - =A0 =A0gtk_label_set_max_width_chars(GTK_LABEL(label), kMaxCharsOnAButt=
on);
> - =A0 =A0gtk_label_set_ellipsize(GTK_LABEL(label), PANGO_ELLIPSIZE_END);
> +
> + =A0 =A0// Ellipsize long bookmark names.
> + =A0 =A0if (node !=3D model->other_node()) {
> + =A0 =A0 =A0gtk_label_set_max_width_chars(GTK_LABEL(label), kMaxCharsOnA=
Button);
> + =A0 =A0 =A0gtk_label_set_ellipsize(GTK_LABEL(label), PANGO_ELLIPSIZE_EN=
D);
> + =A0 =A0}
> +
> =A0 =A0 gtk_box_pack_start(GTK_BOX(box), label, FALSE, FALSE, 0);
> =A0 =A0 SetButtonTextColors(label, provider);
> =A0 }
>
>
>

Expand Messages | Collapse Messages