Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 225007: Fix git-try for people that use it over svn. (Closed)

Created:
11 years, 3 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel, Evan Martin
CC:
chromium-reviews_googlegroups.com, M-A Ruel, yaar
Visibility:
Public.

Description

Fix git-try for people that use it over svn. Committed as r26928 http://src.chromium.org/viewvc/chrome?view=rev&revision=26928 .

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M git-try View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
What better way to start the day than fixing broken tools.
11 years, 3 months ago (2009-09-23 15:41:15 UTC) #1
M-A Ruel
lgtm yeah, that's a good day start.
11 years, 3 months ago (2009-09-23 15:42:05 UTC) #2
Evan Martin
@yaar: it looks like this could use some test code. Maybe at least something that ...
11 years, 3 months ago (2009-09-23 15:45:24 UTC) #3
yaar
Is there a git-try test anywhere I can build on? On Wed, Sep 23, 2009 ...
11 years, 3 months ago (2009-09-23 16:13:13 UTC) #4
Evan Martin
11 years, 3 months ago (2009-09-23 16:35:56 UTC) #5
I don't think so.  If you look at git-cl/test/ there are some
examples.  I think it'd be enough to check in a "smoketest.sh" that
just runs a couple of commands to verify they don't have any syntax
errors.

On Wed, Sep 23, 2009 at 9:12 AM, Yaar Schnitman <yaar@chromium.org> wrote:
> Is there a git-try test anywhere I can build on?
>
> On Wed, Sep 23, 2009 at 8:45 AM, <evan@chromium.org> wrote:
>>
>> @yaar: it looks like this could use some test code. =A0Maybe at least
>> something
>> that does a --dry-run commit via both HTTP and svn to shake out all the
>> simple
>> glitches?
>>
>> http://codereview.chromium.org/225007
>
>

Powered by Google App Engine
This is Rietveld 408576698