Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 225001: Use base/logging from chrome/browser/sync. Add a macro to libjingle's (Closed)

Created:
11 years, 3 months ago by ncarter (slow)
Modified:
9 years, 7 months ago
Reviewers:
brg
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Use base/logging from chrome/browser/sync. Add a macro to libjingle's logging.h to suppress the definition of LOG() and friends unless explicitly requested. Fix gyp paths to overrides files. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27316

Patch Set 1 #

Patch Set 2 : Added README.chromium #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -44 lines) Patch
M chrome/browser/sync/notifier/base/async_dns_lookup.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/notifier/communicator/single_login_attempt.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/notifier/communicator/xmpp_connection_generator.cc View 8 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/sync/notifier/communicator/xmpp_socket_adapter.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/sync/notifier/gaia_auth/gaiaauth.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/notifier/gaia_auth/gaiahelper.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/notifier/gaia_auth/win/win32window.cc View 3 chunks +4 lines, -4 lines 2 comments Download
M third_party/libjingle/README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/libjingle/files/talk/base/logging.h View 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ncarter (slow)
11 years, 3 months ago (2009-09-23 02:11:04 UTC) #1
brg
One minor nit. LGTM++ On 2009/09/23 02:11:04, nick wrote: >
11 years, 3 months ago (2009-09-23 18:10:05 UTC) #2
ncarter (slow)
What's the nit? On Wed, Sep 23, 2009 at 11:10 AM, <brg@chromium.org> wrote: > One ...
11 years, 3 months ago (2009-09-23 18:11:59 UTC) #3
brg
http://codereview.chromium.org/225001/diff/1001/2007 File chrome/browser/sync/notifier/gaia_auth/win/win32window.cc (right): http://codereview.chromium.org/225001/diff/1001/2007#newcode8 Line 8: #include "base/logging.h" You are missing a blank line ...
11 years, 3 months ago (2009-09-23 18:14:26 UTC) #4
ncarter (slow)
11 years, 3 months ago (2009-09-23 20:28:36 UTC) #5
http://codereview.chromium.org/225001/diff/1001/2007
File chrome/browser/sync/notifier/gaia_auth/win/win32window.cc (right):

http://codereview.chromium.org/225001/diff/1001/2007#newcode8
Line 8: #include "base/logging.h"
On 2009/09/23 18:14:26, brg wrote:
> You are missing a blank line betwixt this modules header and base/logging.h

Done.

Powered by Google App Engine
This is Rietveld 408576698