Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2249002: Fix jump targets on ARM to merge virtual frames (really this time).... (Closed)

Created:
10 years, 7 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix jump targets on ARM to merge virtual frames (really this time). Use the jump targets to move the first deferred code to not flush registers in the inlined case (KeyedLoad). Committed: http://code.google.com/p/v8/source/detail?r=4745

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 10

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -137 lines) Patch
M src/arm/codegen-arm.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 2 3 13 chunks +62 lines, -57 lines 0 comments Download
M src/arm/ic-arm.cc View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M src/arm/jump-target-arm.cc View 1 2 1 chunk +4 lines, -7 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 1 chunk +10 lines, -7 lines 0 comments Download
M src/arm/virtual-frame-arm.h View 1 2 6 chunks +12 lines, -12 lines 0 comments Download
M src/arm/virtual-frame-arm.cc View 1 2 2 chunks +39 lines, -30 lines 0 comments Download
M src/codegen.h View 1 2 2 chunks +22 lines, -6 lines 0 comments Download
M src/jump-target-light.cc View 1 2 2 chunks +1 line, -8 lines 0 comments Download
M src/virtual-frame-light-inl.h View 5 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Erik Corry
10 years, 7 months ago (2010-05-26 15:02:51 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/2249002/diff/10002/12001 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2249002/diff/10002/12001#newcode5421 src/arm/codegen-arm.cc:5421: void DeferredReferenceGetNamedValue::Generate() { Maybe add the expected height ...
10 years, 7 months ago (2010-05-27 07:06:21 UTC) #2
Erik Corry
http://codereview.chromium.org/2249002/diff/10002/12001 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2249002/diff/10002/12001#newcode5421 src/arm/codegen-arm.cc:5421: void DeferredReferenceGetNamedValue::Generate() { On 2010/05/27 07:06:21, Søren Gjesse wrote: ...
10 years, 7 months ago (2010-05-27 13:05:44 UTC) #3
Erik Corry
10 years, 7 months ago (2010-05-27 13:39:03 UTC) #4
Erik Corry
10 years, 7 months ago (2010-05-27 13:39:24 UTC) #5

          

Powered by Google App Engine
This is Rietveld 408576698