Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 224012: Renames getTabContentses to getExtensionTabs (Closed)

Created:
11 years, 3 months ago by Nick Baum (Google)
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org, darin (slow to review), brettw, jam, Erik does not do reviews
Visibility:
Public.

Description

Renames getTabContentses to getExtensionTabs. Keeps an alias to getTabContentses for backwards compatibility. BUG=21433 TEST=None

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M chrome/browser/extensions/extension_browsertests_misc.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extension_process_bindings.js View 1 2 chunks +6 lines, -1 line 0 comments Download
M chrome/test/data/extensions/good/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nick Baum (Google)
Fix for this issue: http://code.google.com/p/chromium/issues/detail?id=21433 -Nick
11 years, 3 months ago (2009-09-23 23:19:53 UTC) #1
Aaron Boodman
I think you also need to update chrome/common/extensions/api/extensions_api.json. There may also be unit tests for ...
11 years, 3 months ago (2009-09-23 23:57:53 UTC) #2
Aaron Boodman
Ping? :)
11 years, 2 months ago (2009-10-07 01:31:58 UTC) #3
Nick Baum (Google)
Ha, sorry about that. I think I have a good version of this, but I ...
11 years, 2 months ago (2009-10-07 03:20:11 UTC) #4
Nick Baum (Google)
FYI, added a test extension to the actual bug.
11 years, 2 months ago (2009-10-10 01:20:13 UTC) #5
Nick Baum (Google)
Nevermind, looks like something broke between my manual try bot and my submission. Sigh. Will ...
11 years, 2 months ago (2009-10-10 01:32:31 UTC) #6
Aaron Boodman
11 years, 1 month ago (2009-10-28 07:44:09 UTC) #7
Landed @ r30326.

Powered by Google App Engine
This is Rietveld 408576698