Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 223029: Clean up a few bits of files that I'm about to modify. The only visible chan... (Closed)

Created:
11 years, 3 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
whywhat, sky
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Clean up a few bits of files that I'm about to modify. The only visible change is the removal of some extra spacing Ben erroneously added to the link infobar a while back (clients already do their own spacing as needed, so this just added extra whitespace in mid-sentence). BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27151

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -82 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/views/infobars/infobars.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M views/controls/label.cc View 2 chunks +2 lines, -1 line 1 comment Download
M views/controls/link.h View 3 chunks +3 lines, -3 lines 0 comments Download
M views/controls/link.cc View 5 chunks +55 lines, -69 lines 3 comments Download
M views/controls/textfield/textfield.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Peter Kasting
11 years, 3 months ago (2009-09-24 23:45:53 UTC) #1
sky
One nit, LGTM otherwise. http://codereview.chromium.org/223029/diff/1/5 File views/controls/label.cc (right): http://codereview.chromium.org/223029/diff/1/5#newcode21 Line 21: // static nit: no ...
11 years, 3 months ago (2009-09-25 00:03:51 UTC) #2
Peter Kasting
On 2009/09/25 00:03:51, sky wrote: > http://codereview.chromium.org/223029/diff/1/5#newcode21 > Line 21: // static > nit: no ...
11 years, 3 months ago (2009-09-25 00:08:17 UTC) #3
whywhat
http://codereview.chromium.org/223029/diff/1/2 File views/controls/link.cc (right): http://codereview.chromium.org/223029/diff/1/2#newcode156 views/controls/link.cc:156: normal_color_ = color; Is this a typo? Shouldn't be ...
10 years, 1 month ago (2010-10-27 12:28:12 UTC) #4
Peter Kasting
http://codereview.chromium.org/223029/diff/1/2 File views/controls/link.cc (right): http://codereview.chromium.org/223029/diff/1/2#newcode156 views/controls/link.cc:156: normal_color_ = color; On 2010/10/27 12:28:12, whywhat wrote: > ...
10 years, 1 month ago (2010-10-27 18:23:31 UTC) #5
whywhat
http://codereview.chromium.org/223029/diff/1/2 File views/controls/link.cc (right): http://codereview.chromium.org/223029/diff/1/2#newcode156 views/controls/link.cc:156: normal_color_ = color; On 2010/10/27 18:23:32, Peter Kasting wrote: ...
10 years, 1 month ago (2010-10-28 11:35:23 UTC) #6
Peter Kasting
10 years, 1 month ago (2010-10-28 18:26:37 UTC) #7
On 2010/10/28 11:35:23, whywhat wrote:
> I wasn't about to blame anyone :) I just found someone who touched this code
and
> who might know if this typo was intentional somehow (you never know, right?).
> It's too easy to think you're fixing something obvious while you're actually
> breaking something not commented well-enough.

Ah, sorry, I didn't even connect the dots that you reviewed the other change. 
Also I saw "whywhat" and thought "who is this totally random outside person?". 
So I couldn't figure out why you were interested.

If possible, I suggest changing your "display name" to something akin to your
email or real name, to reduce future confusion...

Powered by Google App Engine
This is Rietveld 408576698